Repository navigation
Use the stdlib Set for the compiler's sets - #8789
Merged
Merged
Conversation
cknitt
added this pull request to stack #8788
October 10, 2026 18:56
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
marked this pull request as ready for review
October 11, 2026 05:33
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Set_ident, Set_int and Set_string are Set.Make instances with the same comparisons; Ext_set and Set_gen are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christoph Knittel <ck@cca.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christoph Knittel <ck@cca.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stdlib-hashset #8789 +/- ##
==================================================
- Coverage 80.64% 80.58% -0.07%
==================================================
Files 458 455 -3
Lines 62523 62231 -292
==================================================
- Hits 50420 50147 -273
+ Misses 12103 12084 -19
🚀 New features to boost your workflow:
|
cristianoc
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of four PRs moving the compiler's own collections onto the OCaml standard library, stacked on #8787. This one covers sets.
Set_ident,Set_intandSet_stringare nowSet.Makeinstances with the same comparison functions, includingExt_string.compare(length first) for strings, so iteration order is unchanged. Call sites use the stdlib argument order (Set_ident.add x s,Set_ident.mem x s,Set_ident.iter f s, …). Element and set types always differ, so the type checker verifies every flipped call.Ext_setandSet_genare removed, together with the ounit tests of their balanced-tree invariants.Output: byte-identical to #8787 on 628 files (Belt, all of
tests/tests/src, and the benchmark stress inputs).Performance: neutral (CPU −0.6%, allocation +0.35% vs master).
🤖 Generated with Claude Code